FindBugs Bug Detector Report
The following document contains the results of FindBugs Report
FindBugs Version is 1.3.9
Threshold is low
Effort is min
Files
org.apache.myfaces.commons.resourcehandler.ExtendedDefaultResourceHandlerSupport
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.commons.resourcehandler.ExtendedDefaultResourceHandlerSupport.getGzipResourcesSuffixes() may expose internal representation by returning ExtendedDefaultResourceHandlerSupport._gzipResourcesSuffix | MALICIOUS_CODE | EI_EXPOSE_REP | 156 | Medium |
| org.apache.myfaces.commons.resourcehandler.ExtendedDefaultResourceHandlerSupport.getResourceLoaders() may expose internal representation by returning ExtendedDefaultResourceHandlerSupport._resourceLoaders | MALICIOUS_CODE | EI_EXPOSE_REP | 420 | Medium |
| Redundant nullcheck of mapping, which is known to be non-null in org.apache.myfaces.commons.resourcehandler.ExtendedDefaultResourceHandlerSupport.calculateResourceBasePath(FacesContext) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 234 | Low |
| Useless control flow in org.apache.myfaces.commons.resourcehandler.ExtendedDefaultResourceHandlerSupport.getFacesServletPrefixMapping(FacesContext, WebRegistration) | STYLE | UCF_USELESS_CONTROL_FLOW | 346 | Medium |
org.apache.myfaces.commons.resourcehandler.ExtendedResourceHandlerImpl
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Redundant nullcheck of libraryName, which is known to be non-null in org.apache.myfaces.commons.resourcehandler.ExtendedResourceHandlerImpl.handleResourceRequest(FacesContext) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 421 | Low |
org.apache.myfaces.commons.resourcehandler.GZIPResourceLoader
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.commons.resourcehandler.GZIPResourceLoader.createCompressedFileVersion(FacesContext, ResourceMeta, File) ignores exceptional return value of java.io.File.delete() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 246 | Medium |
| org.apache.myfaces.commons.resourcehandler.GZIPResourceLoader.createCompressedFileVersion(FacesContext, ResourceMeta, File) ignores exceptional return value of java.io.File.mkdirs() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 245 | Medium |
| org.apache.myfaces.commons.resourcehandler.GZIPResourceLoader.initialize() ignores exceptional return value of java.io.File.mkdirs() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 93 | Medium |
org.apache.myfaces.commons.resourcehandler.config.MyFacesResourceHandlerConfigParser$LibraryHandler
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| MyFacesResourceHandlerConfigParser$LibraryHandler.locator not initialized in constructor | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Not available | Low |
org.apache.myfaces.commons.resourcehandler.resource.BaseResourceHandlerSupport
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.apache.myfaces.commons.resourcehandler.resource.BaseResourceHandlerSupport.getResourceLoaders() return a zero length array rather than null? | STYLE | PZLA_PREFER_ZERO_LENGTH_ARRAYS | 64 | Low |
| Redundant nullcheck of mapping, which is known to be non-null in org.apache.myfaces.commons.resourcehandler.resource.BaseResourceHandlerSupport.calculateResourceBasePath(FacesContext) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 72 | Low |
| Redundant nullcheck of mapping, which is known to be non-null in org.apache.myfaces.commons.resourcehandler.resource.BaseResourceHandlerSupport.getMapping() | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 134 | Low |
org.apache.myfaces.commons.resourcehandler.resource.ExternalContextResourceLoader
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.myfaces.commons.resourcehandler.resource.ExternalContextResourceLoader.RESOURCE_VERSION_CHECKER isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 49 | High |
| org.apache.myfaces.commons.resourcehandler.resource.ExternalContextResourceLoader.VERSION_CHECKER isn't final but should be | MALICIOUS_CODE | MS_SHOULD_BE_FINAL | 42 | High |
org.apache.myfaces.commons.resourcehandler.resource.ResourceLoader$VersionComparator
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.apache.myfaces.commons.resourcehandler.resource.ResourceLoader$VersionComparator be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 86-147 | Medium |
org.apache.myfaces.commons.resourcehandler.resource.ResourceLoaderUtils
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.myfaces.commons.resourcehandler.resource.ResourceLoaderUtils.parseDateHeader(String) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead | PERFORMANCE | DM_NUMBER_CTOR | 75 | Medium |
org.apache.myfaces.commons.resourcehandler.resource.ValueExpressionFilterInputStream
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unwritten field: org.apache.myfaces.commons.resourcehandler.resource.ValueExpressionFilterInputStream.libraryName | CORRECTNESS | UWF_UNWRITTEN_FIELD | 111 | Medium |
| Unwritten field: org.apache.myfaces.commons.resourcehandler.resource.ValueExpressionFilterInputStream.resourceName | CORRECTNESS | UWF_UNWRITTEN_FIELD | 111 | Medium |
org.apache.myfaces.commons.resourcehandler.webapp.config.impl.WebXmlConfigParser$WebConfigHandler
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| WebXmlConfigParser$WebConfigHandler.locator not initialized in constructor | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Not available | Low |
| WebXmlConfigParser$WebConfigHandler.servletNameMappings not initialized in constructor | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Not available | Low |
| WebXmlConfigParser$WebConfigHandler.urlPatterns not initialized in constructor | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Not available | Low |
org.apache.myfaces.commons.resourcehandler.webapp.config.impl._ExternalSpecifications
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Incorrect lazy initialization and update of static field org.apache.myfaces.commons.resourcehandler.webapp.config.impl._ExternalSpecifications.servlet30Available in org.apache.myfaces.commons.resourcehandler.webapp.config.impl._ExternalSpecifications.isServlet30Available() | MT_CORRECTNESS | LI_LAZY_INIT_UPDATE_STATIC | 46-50 | Medium |