PMD Results

The following document contains the results of PMD 6.13.0.

Violations By Priority

Priority 3

org/apache/shiro/crypto/hash/AbstractHash.java

Rule Violation Line
UnusedPrivateMethod Avoid unused private methods such as 'isReserved(String)'. 306

org/apache/shiro/crypto/hash/HashRequest.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'static' on class 'Builder': types nested within an interface type are implicitly static 85224
UnnecessaryModifier Unnecessary modifier 'public' on class 'Builder': members of interface types are implicitly public 85224

org/apache/shiro/crypto/hash/format/DefaultHashFormatFactory.java

Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 211219

org/apache/shiro/crypto/hash/format/ModularCryptFormat.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'TOKEN_DELIMITER': the field is declared in an interface type 31

org/apache/shiro/crypto/hash/format/ProvidedHashFormat.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'ProvidedHashFormat(Class)': enum constructors are implicitly private 4749

Priority 4

org/apache/shiro/crypto/hash/format/DefaultHashFormatFactory.java

Rule Violation Line
UselessParentheses Useless parentheses. 131

Files

org/apache/shiro/crypto/hash/AbstractHash.java

Rule Violation Priority Line
UnusedPrivateMethod Avoid unused private methods such as 'isReserved(String)'. 3 306

org/apache/shiro/crypto/hash/HashRequest.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'static' on class 'Builder': types nested within an interface type are implicitly static 3 85224
UnnecessaryModifier Unnecessary modifier 'public' on class 'Builder': members of interface types are implicitly public 3 85224

org/apache/shiro/crypto/hash/format/DefaultHashFormatFactory.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 131
CollapsibleIfStatements These nested if statements could be combined 3 211219

org/apache/shiro/crypto/hash/format/ModularCryptFormat.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'TOKEN_DELIMITER': the field is declared in an interface type 3 31

org/apache/shiro/crypto/hash/format/ProvidedHashFormat.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'ProvidedHashFormat(Class)': enum constructors are implicitly private 3 4749