PMD Results

The following document contains the results of PMD 5.5.1.

Files

org/apache/shiro/SecurityUtils.java

Violation Line
Useless parentheses. 56

org/apache/shiro/authc/Authenticator.java

Violation Line
Avoid modifiers which are implied by the context 6566

org/apache/shiro/authc/LogoutAware.java

Violation Line
Avoid modifiers which are implied by the context 40

org/apache/shiro/authc/credential/Md2CredentialsMatcher.java

Violation Line
Avoid unused imports such as 'org.apache.shiro.crypto.hash.AbstractHash' 21
Avoid unused imports such as 'org.apache.shiro.crypto.hash.Hash' 22

org/apache/shiro/authc/credential/Md5CredentialsMatcher.java

Violation Line
Avoid unused imports such as 'org.apache.shiro.crypto.hash.AbstractHash' 21
Avoid unused imports such as 'org.apache.shiro.crypto.hash.Hash' 22

org/apache/shiro/authc/credential/Sha1CredentialsMatcher.java

Violation Line
Avoid unused imports such as 'org.apache.shiro.crypto.hash.AbstractHash' 21
Avoid unused imports such as 'org.apache.shiro.crypto.hash.Hash' 22

org/apache/shiro/authc/credential/Sha256CredentialsMatcher.java

Violation Line
Avoid unused imports such as 'org.apache.shiro.crypto.hash.AbstractHash' 21
Avoid unused imports such as 'org.apache.shiro.crypto.hash.Hash' 22

org/apache/shiro/authc/credential/Sha384CredentialsMatcher.java

Violation Line
Avoid unused imports such as 'org.apache.shiro.crypto.hash.AbstractHash' 21
Avoid unused imports such as 'org.apache.shiro.crypto.hash.Hash' 22

org/apache/shiro/authc/credential/Sha512CredentialsMatcher.java

Violation Line
Avoid unused imports such as 'org.apache.shiro.crypto.hash.AbstractHash' 21
Avoid unused imports such as 'org.apache.shiro.crypto.hash.Hash' 22

org/apache/shiro/authc/credential/SimpleCredentialsMatcher.java

Violation Line
Avoid unused imports such as 'java.util.Arrays' 28

org/apache/shiro/authz/annotation/package-info.java

Violation Line
Avoid unused imports such as 'java.lang.annotation.ElementType' 26
Avoid unused imports such as 'java.lang.annotation.Target' 27

org/apache/shiro/authz/aop/PermissionAnnotationHandler.java

Violation Line
Avoid unused imports such as 'org.apache.shiro.authz.annotation.RequiresRoles' 24

org/apache/shiro/authz/permission/PermissionResolverAware.java

Violation Line
Avoid modifiers which are implied by the context 39

org/apache/shiro/authz/permission/RolePermissionResolverAware.java

Violation Line
Avoid modifiers which are implied by the context 39

org/apache/shiro/authz/permission/WildcardPermission.java

Violation Line
Avoid unused imports such as 'java.util.LinkedHashSet' 28

org/apache/shiro/config/IniFactorySupport.java

Violation Line
Avoid unused imports such as 'java.util.HashMap' 28

org/apache/shiro/mgt/AbstractRememberMeManager.java

Violation Line
Avoid unused imports such as 'org.apache.shiro.codec.Base64' 25
Useless parentheses. 266

org/apache/shiro/mgt/DefaultSessionStorageEvaluator.java

Violation Line
Useless parentheses. 63

org/apache/shiro/realm/ldap/DefaultLdapContextFactory.java

Violation Line
These nested if statements could be combined 298313
Useless parentheses. 306
Useless parentheses. 307
Useless parentheses. 308
Unnecessary use of fully qualified name 'javax.naming.AuthenticationException' due to existing import 'javax.naming.AuthenticationException' 310

org/apache/shiro/realm/ldap/JndiLdapContextFactory.java

Violation Line
These nested if statements could be combined 530545
Useless parentheses. 538
Useless parentheses. 539
Useless parentheses. 540
Unnecessary use of fully qualified name 'javax.naming.AuthenticationException' due to existing import 'javax.naming.AuthenticationException' 542

org/apache/shiro/realm/text/PropertiesRealm.java

Violation Line
Avoid empty catch blocks 293295

org/apache/shiro/session/mgt/AbstractValidatingSessionManager.java

Violation Line
Useless parentheses. 291

org/apache/shiro/session/mgt/SimpleSession.java

Violation Line
Useless parentheses. 378
Useless parentheses. 379
Useless parentheses. 380
Useless parentheses. 381
Useless parentheses. 382
Useless parentheses. 383
Useless parentheses. 384

org/apache/shiro/session/mgt/eis/MemorySessionDAO.java

Violation Line
Avoid unused private fields such as 'log'. 58

org/apache/shiro/subject/SimplePrincipalMap.java

Violation Line
Useless parentheses. 234
Useless parentheses. 255
Useless parentheses. 272

org/apache/shiro/subject/Subject.java

Violation Line
Avoid modifiers which are implied by the context 607847

org/apache/shiro/util/AntPathMatcher.java

Violation Line
Useless parentheses. 82
Avoid using a branching statement as the last in a loop. 212
These nested if statements could be combined 270272
These nested if statements could be combined 286288
These nested if statements could be combined 307309
These nested if statements could be combined 350352
Avoid using a branching statement as the last in a loop. 357
Useless parentheses. 406

org/apache/shiro/util/ThreadContext.java

Violation Line
Useless parentheses. 130
Useless parentheses. 185