PMD Results

The following document contains the results of PMD 5.5.1.

Files

org/apache/shiro/web/env/EnvironmentLoader.java

Violation Line
Useless parentheses. 307

org/apache/shiro/web/filter/PathMatchingFilter.java

Violation Line
Avoid unused imports such as 'org.apache.shiro.util.StringUtils' 23

org/apache/shiro/web/filter/authc/AuthenticatingFilter.java

Violation Line
Useless parentheses. 124
Useless parentheses. 146

org/apache/shiro/web/filter/authc/FormAuthenticationFilter.java

Violation Line
Useless parentheses. 183

org/apache/shiro/web/filter/authc/LogoutFilter.java

Violation Line
Avoid unused imports such as 'org.apache.shiro.util.StringUtils' 24
Avoid unused imports such as 'org.apache.shiro.web.filter.mgt.DefaultFilter.logout' 36
These nested if statements could be combined 8789

org/apache/shiro/web/filter/authz/HostFilter.java

Violation Line
Avoid empty if statements 7173

org/apache/shiro/web/mgt/DefaultWebSecurityManager.java

Violation Line
These nested if statements could be combined 170176

org/apache/shiro/web/mgt/DefaultWebSessionStorageEvaluator.java

Violation Line
Useless parentheses. 92

org/apache/shiro/web/servlet/AbstractShiroFilter.java

Violation Line
Useless parentheses. 273
Useless parentheses. 274

org/apache/shiro/web/servlet/Cookie.java

Violation Line
Avoid modifiers which are implied by the context 37
Avoid modifiers which are implied by the context 43
Avoid modifiers which are implied by the context 48

org/apache/shiro/web/servlet/IniShiroFilter.java

Violation Line
Useless parentheses. 283
Useless parentheses. 283

org/apache/shiro/web/servlet/ShiroHttpServletRequest.java

Violation Line
Useless parentheses. 103
Useless parentheses. 198
Unnecessary use of fully qualified name 'java.security.Principal' due to existing import 'java.security.Principal' 224

org/apache/shiro/web/servlet/ShiroHttpServletResponse.java

Violation Line
Useless parentheses. 141
Useless parentheses. 144
Useless parentheses. 148
Useless parentheses. 154
Useless parentheses. 156
Useless parentheses. 167
Useless parentheses. 172
Useless parentheses. 174
Useless parentheses. 190
Useless parentheses. 195
Useless parentheses. 196
Useless parentheses. 199
Useless parentheses. 203
Useless parentheses. 221
Useless parentheses. 235
Useless parentheses. 236
Useless parentheses. 302
Useless parentheses. 302
Useless parentheses. 303
Useless parentheses. 327

org/apache/shiro/web/servlet/ShiroHttpSession.java

Violation Line
Useless parentheses. 118

org/apache/shiro/web/subject/WebSubject.java

Violation Line
Avoid modifiers which are implied by the context 58157

org/apache/shiro/web/tags/SecureTag.java

Violation Line
Avoid unused private fields such as 'log'. 37

org/apache/shiro/web/util/RedirectView.java

Violation Line
Useless parentheses. 232

org/apache/shiro/web/util/WebUtils.java

Violation Line
Useless parentheses. 212
Useless parentheses. 219