2011-12-30 Juan Pablo Santos (juanpablo AT apache DOT org) * 3.0.0-svn-234 * fixed JSPWIKI-690: default set of pages for 3.0 * fixed JSPWIKI-692: FCK.jsp uses TemplateManager.addResourceRequest, which does not exist anymore * most of JSPWIKI-693 (style issues) fixed 2011-09-20 Florian Holeczek * no version bump * modified jspwiki-checkstyle.xml to be compatible with CheckStyle 5.x * corrected a few things CheckStyle was nagging about 2011-09-18 Harry Metske * 3.0.0-svn-233 * JSPWIKI-391: FCK editor ruins the anchors inside the page * JSPWIKI-493: FCK editor adds newlines before and after text formatted as "code" 2011-09-18 Harry Metske * 3.0.0-svn-232 * fixed JSPWIKI-705 (Log a clear hint to a running security manager). 2011-08-21 Florian Holeczek * fixed JSPWIKI-701 (Website must display disclaimer text) * no version bump 2011-08-07 Harry Metske * 3.0.0-svn-231 * fixed JSPWIKI-699 (JBoss complaining about jspwiki.tld and oscache.tld). * a few minor Stripes bugs 2011-07-13 Janne Jalkanen (jalkanen@apache.org) * 3.0.0-incubating-230 * El firsto releaso attempto. 2011-05-13 Juan Pablo Santos (juanpablo AT apache DOT org) * 3.0.0-svn-230 * JSPWIKI-691: Navigation to ./admin/Admin.jsp with a non-authorized user redirects to a blank ./Message.jsp. * JSPWIKI-695: Change note gets sticked upon several revisions. 2011-05-09 Harry Metske * 3.0.0-svn-229 * WikiTagBase sometimes tried to getMessage() on a null exception, added an extra check on that. * JavaDoc fixes * Error.jsp was is own error page causing endless loops, removed the errorPage tag. * Error.jsp was using ${error.realCause.class.name} causing : javax.el.ELException: The identifier [class] is not a valid Java identifier as required by section 1.19 of the EL specification (Identifier ::= Java language identifier). This check can be disabled by setting the system property org.apache.el.parser.SKIP_IDENTIFIER_CHECK to true. An extra getter was added on the MessageActionBean to circumvent this. We should now at least get clearer error messages. 2011-05-08 Harry Metske * 3.0.0-svn-228 * fixed JSPWIKI-689 (InstallActionBean does not create admin user), most code taken from JSPWiki 2.8. * On Install.jsp I also moved the logdir and workdir fields from Advanced to Basic, since they are required fields. * Removed unmappable characters from CreoleToJSPWikiTranslatorTest (causing compile warnings) 2011-04-27 Juan Pablo Santos (juanpablo AT apache DOT org) * 3.0.0-svn-227 * JSPWIKI-636: fixed DefaultAclManagerTest.testPrintAcl(). Saving pages involves calling RenderingManager.getRenderedDocument(), which can return cached or non-cached WikiDocuments. In the first case, ACLs were not associated to current WikiPage, whereas in the second one yes (DefaultAclManager.parseAcl() is called as part of MarkupParser.parse()). * JSPWIKI-636: 27 tests where locale-dependant (test assertions assumed english locale), so TestEngine and WikiContextFactory enforce it when building mock requests. 2011-04-03 Harry Metske * 3.0.0-svn-226 * fixed JSPWIKI-688 (Poor performance of CreoleToJSPWikiTranslator), thanks to Jelmer Kuperus. 2011-03-24 Juan Pablo Santos (juanpablo AT apache DOT org) * 3.0.0-svn-225 * JSPWIKI-636: fixed RPCHandlerTest.testRecentChanges(). JCR Paths are always lower-cased, and ContentManager.getAllPages( String space ) didn't lower-case it's parameter in order to make a JCR path-based query. One test failure remaining. 2011-01-24 Harry Metske * 3.0.0-svn-224 * Extended the list of lucene searchable file suffixes, we now do ".txt", ".ini", ".xml", ".html", "htm", ".mm", ".htm", ".xhtml", ".java", ".c", ".cpp", ".php", ".asm", ".sh", ".properties", ".kml", ".gpx", ".loc" 2010-12-12 Harry Metske * 3.0.0-svn-223 * JSPWIKI-671: WikiPageRenameEvent not fired during page rename. 2010-12-05 Dirk Frederickx * v3.0.0-svn-222 * JSPWIKI-667: Fixed Scorebar issue in Google Chrome. (workaround js error) * JSPWIKI-675: Fixed Unicode support in quickEdit (javascript regexp) * JSPWIKI-674: Fixed support for nested tabbed sections 2010-09-30 Harry Metske * 3.0.0-svn-221 * JSPWIKI-664 SpecialPage renamed, but wikipages not changed. Changed all references to "FindPage" into "Search" . 2010-08-29 Harry Metske * 3.0.0-svn-220 * JSPWIKI-660 Support external properties in WikiEngine (idea from John McKinney) You can now override individual properties in jspwiki.properties using standard Java System properties. 2010-05-16 Harry Metske * 3.0.0-svn-219 * JSPWIKI-646 JSPWiki cannot run without unpacking the war file 2010-05-08 Harry Metske * 3.0.0-svn-218 * JSPWIKI-392 and JSPWIKI-442 invalid asserted usernames 2010-03-27 Andrew Jaquith * 3.0.0-svn-217 * Renamed EventResolution to AjaxResolution (I had made changes similar to AJAX/JSON to his, independently). 2010-03-21 Dirk Frederickx * v3.0.0-svn-216 : AJAX/JSON fixes. * EventResolution now returns a static JSON object iso of JavaScriptResolution. JSON objects are more safe (no eval) but assume that the converted java beans are acyclical. (which is ok in our case) The overall AJAX/JSON handling is still work in progress. * The client javascript is updated accordingly, with a simplified Stripes.submitFormEvent() * The Preview functionality is now working through JSON objects. * I'm still working on the quick-navigation search functionality. For now, it is broken: the SearchActionBean.quickSearch() needs to some update to use the new json format. * Fixed the AttachmentTab so slimbox preview of attachments is working again. * Fixed the section edit links. * Fixed the section handling routines. Apparently the element with ID="pagecontent" was removed. 2010-03-19 Andrew Jaquith * 3.0.0-svn-215 * Re-wrote ReferenceManager (again) to use JCR UUIDs internally to track references between pages. This change means that the nagging PageRenamer unit test failures are now fixed. RefManager is also considerably simpler for rename cases, although some of that is offset by slight added complexity in ContentManager for add and delete cases. * New singleton-per-wiki class WikiPathResolver, part of the org.apache.content package, caches UUIDs and WikiPaths. It also constructs canonical WikiPaths that based on WikiPage ATTR_TITLE attributes from the JCR. This ensures consistent naming. These too are cached. The caching is primitive and *should* use EHcache, but doesn't yet. It *probably* makes sense to move logic from WikiEngine.getFinalPageName (and related code) here, but that wasn't a goal for this checkin. * As of this build, we have just 2 failing unit tests: one XML-RPC test and one DefaultAclManager test. I will add more RefManager tests to exercise UUID-based references more thoroughly (although the coverage is decent now as it is). 2010-03-08 Andrew Jaquith * 3.0.0-svn-214 * Fixed feature that was broken: localized strings needed by Dirk's JavaScript works again. The code has also been refactored slightly so that it cached rather than having to continually hit the disk looking for resource bundles on every request. 2010-03-03 Andrew Jaquith * 3.0.0-svn-213 * Removed old URLConstructors. Fixed bug in StripesUrlContructor that caused it to exhibit slightly behavior different different behavior than DefaultUrlContructor. It now generates URLs identically. Method parsePage() was removed from UrlContructor's interface spec. (The only URLConstructor implementation is StripesUrlConstructor, anyway, it doesn't need to do any page-param parsing because the framework takes care of it.) * Removed WikiServlet. All of its functionality had been previously moved elsewhere, and it was not being used in web.xml either. Also removed SpamFilter; the content-inspection package essentially replaces it (and is far more flexible). * Fixed bug that popped up in Preferences.jsp regarding skin listings. * Slightly changed how EditActionBean.edit() works. It now forwards directly to the editor JSPs. These JSPs now render EditorLayout.jsp, which allows each editor to load its own resources (per mailing list discussion). Edit.jsp's contents essentially morph into EditorLayout.jsp. * Fixed bug that caused ReferenceManager tests to fail. 2010-02-28 Andrew Jaquith * 3.0.0-svn-212 * Exceptions caught by WikiTagBase (and subclass tags) are now re-thrown so that they propagate upstream. Previously, doCatch() was swallowing them, which made for "interesting" JSP debugging. * Edit.jsp, Wiki.jsp, and PageInfo.jsp changed to put the edit tab on the right. For editing, the live-preview feature was moved to a new "Preview" tab, also on the right. The View tab now simply displays the most recent save. * The Error.jsp references were made consistent in all JSPs. Rather than use JSTL syntax (which won't evaluate when used with <% page errorPage %> tag), the references now all use /Error.jsp, which itself jsp:includes the template JSP Error.jsp using JSTL. This makes the error page customizable per-template, but still very easy to use. * Cleaned out all of the deadwood in TemplateManager. Deprecated IncludeResourcesTag and RequestResourceTag. Resources can (and should) be included directly in template JSPs. * Small changes to Admin/AdministerProfiles action beans as part of a gradual overhaul to the Admin JSPs, which are being Stripesed. 2010-02-28 Dirk Frederickx * v3.0.0-svn-211 : line up with latest template/stripes changes * JSPWIKI-429: Upgrade of Slimbox (viewer for attachments), and adjust it to v3.X of JSPWiki. Various media formats are now supported so you can view youtube or facebook videos, other wikipages, or even external web-pages. Still working on a use as inline media viewer. (iso popup viewer) * JSPWIKI-431 Multi-file upload is now supported with Stripes backend. (improved gui) You can add or remove files (upto 5) before you press the upload button. All attachments are uploaded with the same change note. * JSPWIKI-362 - (still experimental) Added an wysiwyg editor to JSPWiki, based on mooeditable. (MIT license) This is a light-weight editor, based on mootools. Future extensions will improve integration with JSPWiki e.g. adding ajax based suggestion-menu, attachment previews, etc... Interaction with Stripes back-end needs more work. * Fixed and simplified the %%category style to work with the stripes ViewActionBean.ajaxCategories(). This replaces the AJAXCategories.jsp. * Upgrade to mootools-core to 1.2.4, mootools-more to 1.2.4.4 * Updated %%prettify style, adding line numbers to code-blocks. 2010-01-06 Harry Metske * 3.0.0-svn-210 * fixed a couple of Plugin unit tests (support for wiki spaces is not yet there), only the ReferringPagesPlugin still fails. 2010-02-27 Andrew Jaquith * 3.0.0-svn-209 * Moved top-level Error.jsp into the templates directory. * Slight tweaks to the admin pages, which are being re-organized. Security config is now one of the tabs on Admin.jsp. User management partially re-worked but not yet functional. 2010-02-23 Andrew Jaquith * 3.0.0-svn-208 * Useful tweaks to the AJAX-related Stripes JavaScript. The client-side JavaScript now injects validation errors and messages that were generated server-side by an EventResolution, using the same prefixes and headers defined in CoreResources for "normal" JSP validation errors and messages. Generation of an EventResolution for AJAX methods that generate errors is automatic when the event method is annotated with @AjaxEvent. Practically speaking, what it means is this: to call an Stripes method via Ajax, just annotate the method with @AjaxEvent. Then, client-side scripts need only call the JavaScript function Stripes.submitFormEvent(). The rest is MAGIC. * Captcha interface gains an isEnabled() method to allow SpamProtect tag to check whether the CAPTCHA is operational before generating output. This is required in stand-alone or testing scenarios where an outbound network connection cannot be assumed. * Moved the admin-related JSPs to the templates directory. Added a new layout JSP, StaticLayout.jsp, that is used with template JSPs that do not need dynamic content, such as Install.jsp. Among other things, this allows admin-related JSPs to look more like ordinary pages, and use the same CSS. * Tweaked TemplateManager to make the "resource resolver" initialize safely even when the WikiEngine does not. This means the 'templates' JSTL scripting variable can be used everywhere, for example in Install.jsp, Error.jsp or any pages that must load safely. * Moved all images in top-level /images directory to template /images dir, and made code/JSP changes to make sure they can be "found" as needed by the TemplateManager resource resolver. 2010-02-20 Andrew Jaquith * 3.0.0-svn-207 * Fixed 2 failing Scandic page-name URL generation tests. Page names are now encoded as UTF-8. Also patched Group- PageName- and PrincipalTypeConverter to ensure that incoming parameters are properly decoded, which they were not before. Added a Scandic page-name test to ViewActionBeanTest. * [JSPWIKI-510] Restored AJAX quicksearch. It now respects page ACLs, too. Moved the AJAX "suggestions" method to (new) EditDialogActionBean, which is a placeholder for now. Removed JSON global bridge from SearchManager. * [JSPWIKI-635] Disabled the snip-editor feature that was interfering with editor form submission and causing double postings. This is a crude hack until Dirk is able to look at the root cause more closely. :) * [JSPWIKI-180] Removed ISO-8859-1 support from ExternalDiffProvider, WikiEngine, AbstractFileProvider, TestEngine and a few tests. * Fixed multiple bugs in Preferences and Preferences.jsp. Asserted names were not being set when "save prefs" button was pushed. PreferencesLocalePicker was not correctly matching incoming browser Locales to those available on the server. Time zones were not correctly being set. Preferences also had a static-method fetish, which was unnatural. It has been refactored completely and thoroughly. * [JSPWIKI-382] Removed posteditor. Moved Stripes AJAX function to jspwiki-common.js. Light cleanup of unneeded functions in prefs/edit JS. 2010-02-14 Andrew Jaquith * 3.0.0-svn-206 * Fixed bug in TemplateResolution that prevented some JSPs from resolving. * Installed StripesURLContructor as the default (and only) URL constructor. URLs are constructed according to the @UrlBinding annotations in the ActionBeans. Because of the checkins svn-201 through -203, the generated URLs are identical to the ones previously generated by DefaultURLConstructor (with one or two exceptions are previously noted). In the Beta timeframe, the FileBasedActionResolver will allow URL bindings to be externalized. The other URLConstructors will be removed before Beta... but not today. * Changed a few classes that depend on Stripes to use "lazy initialization." WikiContextFactory and StripesURLConstructor must lazily initialize because they depend on StripesFilter being initialized first. Cleaned up TestEngine also: it now initializes a full mock Stripes filter stack at startup. * Eliminated WikiRuntimeConfiguration: it is no longer needed because WikiEngine can easily be obtained without needing a special Stripes config class. Less classes are always better. * Renamed ShortUrlRedirectFilter to ShortUrlFilter. 2010-02-12 Andrew Jaquith * 3.0.0-svn-205 * Introduced TemplateResolution, which forwards the user to the appropriate resource in /templates/